PedanticHacker | 2020-07-23 21:39:34 UTC | #1
Hello, @martin! :slight_smile:
So I have an interesting problem to solve. I am coding a chess GUI application. I have a QTableWidget table for the chess moves to be displayed in two columns, column 0 for the White player and column 1 for the Black player. When I click on a cell and that cell becomes selected, the chessboard position changes accordingly.
Now I want to code that if the user adds a new chess move in that particular position, while rows are inserted below that currently selected row, to remove all those subsequent rows. So, if the chess move added is for the White player, insert a new row and add that chess move to column 0 and remove subsequent rows; but if the chess move added is for the Black player, overwrite the item in column 1 and also remove subsequent rows.
My slot method looks like this:
@pyqtSlot(chess.Move)
def on_new_move_made(self, move):
"""Inserts a new move into the table of chess moves in SAN
(Standard Algebraic Notation) format.
"""
if settings.board.turn == chess.WHITE:
self.row = self.moves_widget.rowCount()
self.column = 0
self.moves_widget.insertRow(self.row)
elif settings.board.turn == chess.BLACK:
self.column = 1
san_move = settings.board.san(move)
self.new_move = QTableWidgetItem(san_move)
self.moves_widget.setItem(self.row, self.column, self.new_move)
self.moves_widget.setCurrentItem(self.new_move)
self.moves_widget.scrollToBottom()
I'm frustrated. Please help me out. Thank you!
martin | 2020-07-29 14:37:25 UTC | #2
Create GUI Applications with Python & Qt5 by Martin Fitzpatrick — (PyQt5 Edition) The hands-on guide to making apps with Python — Over 10,000 copies sold!
Hey @PedanticHacker thanks for the post and welcome to the forum. Sorry for the delay in replying -- this wasn't so simple to figure out (more the logic than Qt specific stuff).
If I understand your problem correctly, you want the user to basically "overwrite" previous moves in the list at any time, by selecting a row and then adding the move? If a row is selected and there are subsequent rows then you want to delete the following.
The tricky part really is how to handle the current white/black state. I've gone for the following --
- if a row is selected all subsequent rows are deleted.
- if the next move is a white move, it will always add a new row after the selected row
- if the next move is a black move, it will always replace the black move on the selected row
The following is a fully-working example. I've defined a simply Move class and a move generator, which toggles between white/black turns and returns positions that follow chess rules (I think, I don't really know).
from PyQt5.QtWidgets import QTableWidget, QVBoxLayout, QWidget, QPushButton, QTableWidgetItem, QMainWindow, QApplication
from random import choice
WHITE = 0
BLACK = 1
class Move:
def __init__(self, turn, move):
self.turn = turn
self.move = move
def __str__(self):
return "{} {}".format(self.turn, self.move)
def chess_moves():
"""
Generator producing chess moves.
"""
turn = WHITE
while True:
move_str = choice('KQRBN ') + choice('abcdefgh') + choice('12345678')
yield Move(turn, move_str)
# Cycle the white/black turns.
if turn == WHITE:
turn = BLACK
else:
turn = WHITE
class MainWindow(QMainWindow):
def __init__(self):
super().__init__()
self.moves = chess_moves()
self.moves_widget = QTableWidget()
self.moves_widget.setColumnCount(2)
self.moves_widget.setHorizontalHeaderLabels(['White','Black'])
self.btn = QPushButton("Move")
self.btn.pressed.connect(self.add_chess_move)
layout = QVBoxLayout()
layout.addWidget(self.moves_widget)
layout.addWidget(self.btn)
w = QWidget()
w.setLayout(layout)
self.setCentralWidget(w)
def add_chess_move(self):
move = next(self.moves)
selected = self.moves_widget.selectedIndexes()
if selected:
row = selected[0].row() # Get row of first selected item.
# Row is selected, delete all after.
while self.moves_widget.rowCount() > row + 1:
self.moves_widget.removeRow(row + 1)
# Clear selection so we don't re-delete next time.
self.moves_widget.clearSelection()
row = self.moves_widget.rowCount()-1
# White always adds a new row.
if move.turn == WHITE:
row += 1
self.moves_widget.setRowCount(row+1)
item = QTableWidgetItem(move.move)
column = move.turn
self.moves_widget.setItem(row, move.turn, item)
self.moves_widget.scrollToBottom()
app = QApplication([])
w = MainWindow()
w.show()
app.exec_()
As shown, for deleting rows the simplest option is to delete the row after the current one repeatedly, until the table is empty. Since the subsequent moves will "scroll up" by doing this you empty the list after that point.
Saying all this, I wonder if you've come across the model views? Using these you could represent your list of moves as a simple Python list and avoid all this manipulation in the table itself -- you could just chop off the end of a list and be done.
Hope this helps!
PedanticHacker | 2020-07-29 18:54:15 UTC | #3
Thanks for your answer, @martin!
Is it also possible I use a combination of QTableWidget's currentRow() and/or currentColumn() methods with setRowCount()? So, if the currently selected row is, for example, 5 and the table has, like, 10 rows and a new chess move was inserted, I'd just set a new row count and be done with this. But I wasn't able to make this work. Am I even thinking in the right direction?
martin | 2020-07-29 19:40:12 UTC | #4
You're quite right! The block can be replaced with ...
if selected:
row = selected[0].row() # Get row of first selected item.
# Row is selected, delete all after.
self.moves_widget.setRowCount(row + 1)
# Clear selection so we don't re-delete next time.
self.moves_widget.clearSelection()
You need to set the row count to the selected row number plus one because the row numbers are zero indexed. So if you select the first (0th) row, you're selecting row 0 and want 1 rows total.
For the currentColumn are you wanting to replace the white move and clear the black move if it's the white's turn and you select a row (rather than start a new one always)?
PedanticHacker | 2020-07-29 22:50:35 UTC | #5
We're getting close to the solution! :slight_smile:
I think it would be simpler to replace the White's move and use the takeItem() method of QTableWidget to remove the Black's move (if it is White's turn), and remove subsequent rows. If the turn is Black's, then the item is automatically replaced, so here we should only remove subsequent rows.
I've tested your code and it removes rows after the currently selected row on new move insertion. However, we're not quite there yet, because only subsequent rows are removed, but the new move is not displayed.
Here's my updated slot code...
@pyqtSlot(chess.Move)
def on_new_move_made(self, move):
"""Inserts a new move into the table of chess moves in SAN
(Standard Algebraic Notation) format.
"""
move_selected = self.moves_widget.selectedIndexes()
if move_selected:
# Get the row number of the currently selected chess move
# for the white player.
white_player = 0
row = move_selected[white_player].row()
# A new chess move is made, so delete all move entries
# after it.
self.moves_widget.setRowCount(row + 1)
# Clear the chess move selection so that the entry of the
# move is not re-deleted on new move insertion.
self.moves_widget.clearSelection()
elif not move_selected:
if settings.board.turn == chess.WHITE:
self.row = self.moves_widget.rowCount()
self.column = 0
self.moves_widget.insertRow(self.row)
elif settings.board.turn == chess.BLACK:
self.column = 1
san_move = settings.board.san(move)
self.new_move = QTableWidgetItem(san_move)
self.moves_widget.setItem(self.row, self.column, self.new_move)
self.moves_widget.scrollToBottom()
martin | 2020-08-04 17:35:06 UTC | #6
I think this does what you're looking for ---
from PyQt5.QtWidgets import QTableWidget, QVBoxLayout, QWidget, QPushButton, QTableWidgetItem, QMainWindow, QApplication
from random import choice
WHITE = 0
BLACK = 1
class Move:
def __init__(self, turn, move):
self.turn = turn
self.move = move
def __str__(self):
return "{} {}".format(self.turn, self.move)
def chess_moves():
"""
Generator producing chess moves.
"""
turn = WHITE
while True:
move_str = choice('KQRBN ') + choice('abcdefgh') + choice('12345678')
yield Move(turn, move_str)
# Cycle the white/black turns.
if turn == WHITE:
turn = BLACK
else:
turn = WHITE
class MainWindow(QMainWindow):
def __init__(self):
super().__init__()
self.moves = chess_moves()
self.moves_widget = QTableWidget()
self.moves_widget.setColumnCount(2)
self.moves_widget.setHorizontalHeaderLabels(['White','Black'])
self.btn = QPushButton("Move")
self.btn.pressed.connect(self.add_chess_move)
layout = QVBoxLayout()
layout.addWidget(self.moves_widget)
layout.addWidget(self.btn)
w = QWidget()
w.setLayout(layout)
self.setCentralWidget(w)
def add_chess_move(self):
move = next(self.moves)
item = QTableWidgetItem(move.move)
selected = self.moves_widget.selectedIndexes()
if selected:
# We have a selected row.
row = selected[0].row() # Get row of first selected item.
# Row is selected, delete all after.
self.moves_widget.setRowCount(row + 1)
# Clear selection so we don't re-delete next time.
self.moves_widget.clearSelection()
# Replace move in column 1, clear column 2.
self.moves_widget.setItem(row, move.turn, item)
if move.turn == WHITE:
# Clear column 2 (black)
self.moves_widget.takeItem(row, BLACK)
else:
# Nothing is selected
row = self.moves_widget.rowCount() - 1
if move.turn == WHITE:
# Append a row.
row += 1
self.moves_widget.setRowCount(row + 1)
column = move.turn
self.moves_widget.setItem(row, move.turn, item)
self.moves_widget.scrollToBottom()
app = QApplication([])
w = MainWindow()
w.show()
app.exec_()
I split out the two states "adding with selected" and "adding with no selection" to separate branches to keep things simple.
If you select a row when it's black's turn, then the black move will be replaced on the selected row. If you select a row when it's white's turn, then the white move will be replaced, and the black move cleared.
PedanticHacker | 2020-08-12 19:18:06 UTC | #7
Based on your example, I can now declare my problem solved. Thank you, @martin! :slight_smile:
My slot now looks like this...
python@pyqtSlot(chess.Move) def on_new_move_made(self, move): """Inserts a new move into the table of chess moves in SAN (Standard Algebraic Notation) format. """ row = self.moves_widget.rowCount() column = 0 if settings.board.turn == chess.WHITE else 1 san_move = settings.board.san(move) new_move = QTableWidgetItem(san_move) selected_move = self.moves_widget.selectedIndexes() if not selected_move: if settings.board.turn == chess.WHITE: self.moves_widget.setRowCount(row + 1) elif settings.board.turn == chess.BLACK: row -= 1 elif selected_move: index = 0 row = selected_move[index].row() if settings.board.turn == chess.WHITE: self.moves_widget.setRowCount(row + 1) self.moves_widget.insertRow(row + 1) row += 1 elif settings.board.turn == chess.BLACK: self.moves_widget.setRowCount(row + 1) self.moves_widget.setItem(row, column, new_move) self.moves_widget.clearSelection() self.moves_widget.scrollToBottom()
If you have any optimization suggestions, please let me know. Thanks again!
PedanticHacker | 2020-08-12 19:18:06 UTC | #8
I've updated my code a bit. I'm posting this for my personal future reference and for anyone that might encounter a similar problem. Below is the refactored code.
@pyqtSlot(chess.Move)
def add_new_move(self, move):
"""Inserts a new move into the table of chess moves in SAN
(Standard Algebraic Notation) format.
"""
row = self.moves_widget.rowCount()
column = 0 if settings.board.turn == chess.WHITE else 1
number_of_columns = self.moves_widget.columnCount()
move_index = (row * number_of_columns) + column
settings.board.move_stack[move_index:-1]
san_move = settings.board.san(move)
new_move = QTableWidgetItem(san_move)
if settings.board.turn == chess.WHITE:
self.moves_widget.setRowCount(row + 1)
elif settings.board.turn == chess.BLACK:
row -= 1
self.moves_widget.setItem(row, column, new_move)
self.moves_widget.scrollToBottom()
self.svg_widget.move_sound_played.emit()
